Validate fill, stroke, and opacity properties. #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2016
Closed
Contributor
|
What are the slight improvements? Saves us doing a diff between your PR and #162. :) |
Contributor
Author
|
Added some test cases, reworked how |
This allows concise description of complex ValidationTypes, using syntax parallel to that in the official CSS specification. This patch just implements the mechanism; a follow-up patch uses it to simplify existing ValidationTypes.
As a side-effect, we also pushed handling the `inherit` option out of most ValidationTypes and moved it into the specification in the Properties table. I expect to refactor this further in the future to make handling of inherit/initial/unset automatic and implicit.
I've updated several simple ValidationType functions to show how this can be used to simplify common matchers. It will also be used in a follow-up patch to validate the `font-variant-alternates` property which involves a large number of CSS function options.
Originally based on PR CSSLint#162 by Onno van der Zee <ovanderzee@iprofs.nl>. Fixes: CSSLint#162
02f0681 to
30b3261
Compare
Contributor
Author
XhmikosR
added a commit
that referenced
this pull request
Feb 6, 2016
Validate fill, stroke, and opacity properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase/squash/slight improvement to PR #162.